Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Load all language colours #467

Merged
merged 32 commits into from
Aug 19, 2021
Merged

Load all language colours #467

merged 32 commits into from
Aug 19, 2021

Conversation

Nixinova
Copy link
Contributor

@Nixinova Nixinova commented Aug 10, 2021

Using the latest version of Nixinova/Linguist allows colors to be grabbed straight from it instead of the GH query.

@Nixinova
Copy link
Contributor Author

Hm, my test may not be enough as everything in recent is also in most-used. Also unsure of the Vercel failure.

@Nixinova Nixinova marked this pull request as draft August 11, 2021 00:03
@Nixinova
Copy link
Contributor Author

Yeah, currently misses Ruby, but does load Dockerfile.

image

@lowlighter
Copy link
Owner

Nice work 👍

Also unsure of the Vercel failure.

Seems that ??= operator is not yet supported by vercel 😕

This reverts commit 8cb6f1b.
@Nixinova
Copy link
Contributor Author

Not sure why C isn't getting any colour...

image

@Nixinova
Copy link
Contributor Author

Closing until I can figure out whats wrong without spamming Vercelbot

@Nixinova Nixinova closed this Aug 17, 2021
@Nixinova
Copy link
Contributor Author

Got it working 🎉

image

@lowlighter
Copy link
Owner

Thanks a lot for your awesome contributions to the language plugin!

@lowlighter lowlighter merged commit 359ff46 into lowlighter:master Aug 19, 2021
@github-actions github-actions bot locked and limited conversation to collaborators Sep 3, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Indepth language analysis doesn't load all language colors
2 participants